Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure with custom type test #1512

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Conversation

gayyappan
Copy link
Contributor

Fix tests that fail like so:
test=# CREATE CAST (customtype AS bigint)
test-# WITHOUT FUNCTION AS ASSIGNMENT;
ERROR: source and target data types are not physically compatible

@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #1512 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1512      +/-   ##
==========================================
+ Coverage   91.45%   91.81%   +0.36%     
==========================================
  Files         144      142       -2     
  Lines       21442    20511     -931     
==========================================
- Hits        19609    18832     -777     
+ Misses       1833     1679     -154
Flag Coverage Δ
#cron ?
#pr 91.81% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/plan_add_hashagg.c 43.33% <0%> (-45.01%) ⬇️
src/telemetry/uuid.c 84.61% <0%> (-15.39%) ⬇️
src/planner_import.c 58.65% <0%> (-11.48%) ⬇️
src/cache_invalidate.c 78.12% <0%> (-2.44%) ⬇️
src/bgw_policy/chunk_stats.c 83.92% <0%> (-1.56%) ⬇️
src/loader/loader.c 91.57% <0%> (-1.25%) ⬇️
src/histogram.c 89.02% <0%> (-1.22%) ⬇️
src/estimate.c 86.17% <0%> (-0.83%) ⬇️
src/telemetry/telemetry.c 79.55% <0%> (-0.71%) ⬇️
src/cache.c 84.82% <0%> (-0.65%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e75c27...aab4007. Read the comment docs.

Fix tests that fail like so:
test=# CREATE CAST (customtype AS bigint)
test-# WITHOUT FUNCTION AS ASSIGNMENT;
ERROR:  source and target data types are not physically compatible
@gayyappan gayyappan merged commit 874b451 into timescale:master Nov 5, 2019
@cevian cevian added this to the 1.5.1 milestone Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants